Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: ui/keyboard/keyboard_controller_unittest.cc

Issue 25111002: Only show virtual keyboard on primary root window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a TODO Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/keyboard_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller_unittest.cc
diff --git a/ui/keyboard/keyboard_controller_unittest.cc b/ui/keyboard/keyboard_controller_unittest.cc
index 1d461166ff684cd10c0432481b46980d356fb837..36505200d4199eaf9b59d02c590863d91a9dead9 100644
--- a/ui/keyboard/keyboard_controller_unittest.cc
+++ b/ui/keyboard/keyboard_controller_unittest.cc
@@ -227,7 +227,7 @@ class KeyboardControllerTest : public testing::Test {
};
TEST_F(KeyboardControllerTest, KeyboardSize) {
- scoped_ptr<aura::Window> container(controller()->GetContainerWindow());
+ aura::Window* container(controller()->GetContainerWindow());
gfx::Rect bounds(0, 0, 100, 100);
container->SetBounds(bounds);
@@ -252,11 +252,10 @@ TEST_F(KeyboardControllerTest, ClickDoesNotFocusKeyboard) {
window->Show();
window->Focus();
- scoped_ptr<aura::Window> keyboard_container(
- controller()->GetContainerWindow());
+ aura::Window* keyboard_container(controller()->GetContainerWindow());
keyboard_container->SetBounds(root_bounds);
- root_window()->AddChild(keyboard_container.get());
+ root_window()->AddChild(keyboard_container);
keyboard_container->Show();
ShowKeyboard();
@@ -297,12 +296,11 @@ TEST_F(KeyboardControllerTest, VisibilityChangeWithTextInputTypeChange) {
TestTextInputClient no_input_client_1(ui::TEXT_INPUT_TYPE_NONE);
input_method->SetFocusedTextInputClient(&input_client_0);
- scoped_ptr<aura::Window> keyboard_container(
- controller()->GetContainerWindow());
+ aura::Window* keyboard_container(controller()->GetContainerWindow());
scoped_ptr<KeyboardContainerObserver> keyboard_container_observer(
- new KeyboardContainerObserver(keyboard_container.get()));
+ new KeyboardContainerObserver(keyboard_container));
keyboard_container->SetBounds(root_bounds);
- root_window()->AddChild(keyboard_container.get());
+ root_window()->AddChild(keyboard_container);
EXPECT_TRUE(keyboard_container->IsVisible());
« no previous file with comments | « ui/keyboard/keyboard_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698