Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: ui/keyboard/keyboard_controller.h

Issue 25111002: Only show virtual keyboard on primary root window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a TODO Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc ('k') | ui/keyboard/keyboard_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller.h
diff --git a/ui/keyboard/keyboard_controller.h b/ui/keyboard/keyboard_controller.h
index e9e5890327e71fe77b869ccbc9cf749d5cc7810c..dd044dc9d533eee90983288401b7c60812bea62a 100644
--- a/ui/keyboard/keyboard_controller.h
+++ b/ui/keyboard/keyboard_controller.h
@@ -39,8 +39,8 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
explicit KeyboardController(KeyboardControllerProxy* proxy);
virtual ~KeyboardController();
- // Returns the container for the keyboard, which is then owned by the caller.
- // It is the responsibility of the caller to Show() the returned window.
+ // Returns the container for the keyboard, which is owned by
+ // KeyboardController.
aura::Window* GetContainerWindow();
// Hides virtual keyboard and notifies observer bounds change.
@@ -59,7 +59,6 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
// aura::WindowObserver overrides
virtual void OnWindowHierarchyChanged(
const HierarchyChangeParams& params) OVERRIDE;
- virtual void OnWindowDestroying(aura::Window* window) OVERRIDE;
// InputMethodObserver overrides
virtual void OnTextInputTypeChanged(
@@ -80,7 +79,7 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
bool WillHideKeyboard() const;
scoped_ptr<KeyboardControllerProxy> proxy_;
- aura::Window* container_;
+ scoped_ptr<aura::Window> container_;
ui::InputMethod* input_method_;
bool keyboard_visible_;
base::WeakPtrFactory<KeyboardController> weak_factory_;
« no previous file with comments | « chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc ('k') | ui/keyboard/keyboard_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698