Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc

Issue 25111002: Only show virtual keyboard on primary root window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reviews Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/shell.cc ('K') | « chrome/browser/extensions/api/input/input.cc ('k') | ui/keyboard/keyboard_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc
diff --git a/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc b/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc
index dfa012a09a59b4f35900f14a4225181c6c0f565b..2650ab8dceb5580ea87c0c9503990771277b4575 100644
--- a/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc
+++ b/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc
@@ -140,6 +140,11 @@ bool AshKeyboardControllerProxy::OnMessageReceived(
void AshKeyboardControllerProxy::ShowKeyboardContainer(
aura::Window* container) {
+ // TODO(bshe): Implements logic to decide which root window should display
varkha 2013/10/04 01:54:07 nit: s/Implements/Implement ?
bshe 2013/10/04 03:04:39 Done.
+ // virtual keyboard. http://crbug.com/303429
+ if (container->GetRootWindow() != ash::Shell::GetPrimaryRootWindow())
+ NOTIMPLEMENTED();
+
KeyboardControllerProxy::ShowKeyboardContainer(container);
gfx::Rect showing_area =
ash::DisplayController::GetPrimaryDisplay().work_area();
« ash/shell.cc ('K') | « chrome/browser/extensions/api/input/input.cc ('k') | ui/keyboard/keyboard_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698