Only show virtual keyboard on primary root window

ash/root_window_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/root_window_controller.h"
 
 #include <queue>
 #include <vector>
 
 #include "ash/ash_constants.h"
@@ skipping 502 matching lines @@
       GetContainer(kShellWindowId_DefaultContainer)->children();
   for (aura::Window::Windows::const_reverse_iterator iter = windows.rbegin();
        iter != windows.rend(); ++iter) {
     if (wm::GetWindowState(*iter)->IsFullscreen())
       return *iter;
   }
   return NULL;
 }
 
 void RootWindowController::InitKeyboard() {
-  if (keyboard::IsKeyboardEnabled()) {
-    aura::Window* parent = root_window();
-
+  aura::Window* parent = root_window();
+  // Restricts virtual keyboard to primary root window.
+  if (keyboard::IsKeyboardEnabled() &&
+      Shell::GetPrimaryRootWindow() == parent) {
     keyboard::KeyboardControllerProxy* proxy =
         Shell::GetInstance()->delegate()->CreateKeyboardControllerProxy();
     keyboard_controller_.reset(

[oshima, 2013/09/28 04:37:27]

If there should be only one KeyboardCOntroller, shouldn't it
be in shell? Then shell call this function in Init() like this

if (KeyboardEnabled()) {
  primary_root->InitKeyboard(keyboard_controller);
}

[bshe, 2013/09/30 18:20:50]

+sadrul

I am happy to do the suggested change. But I dont know the code very well to be
certain that it wont cause any other unexpected behavior. I suspect it should be
fine. Just want to +sadrul to confirm before I do it.

On 2013/09/28 04:37:27, oshima wrote:

[sadrul, 2013/09/30 18:31:50]

Yeah, if we decide to show the keyboard just on the primary root window, then as
oshima suggests, it should be in the Shell.

I believe the primary root-window can change at runtime (e.g. when
attaching/detaching monitors), so you would need to make sure the VK deals with
that case correctly.

Also note that the primary root-window may not be the one that has touch
capability, and it doesn't sound like a good UI to have the input-box in one
monitor and the VK in another. The decision to only show the virtual keyboard on
the primary root-window should perhaps be revisited (e.g. if we show the VK in
just one monitor, then perhaps don't show it for textboxes in any other monitor,
or allow the user to move the keyboard across monitors etc.).

         new keyboard::KeyboardController(proxy));
 
     keyboard_controller_->AddObserver(shelf()->shelf_layout_manager());
     keyboard_controller_->AddObserver(panel_layout_manager_);
 
     aura::Window* keyboard_container =
         keyboard_controller_->GetContainerWindow();
     keyboard_container->set_id(kShellWindowId_VirtualKeyboardContainer);
     parent->AddChild(keyboard_container);
     keyboard_container->SetBounds(parent->bounds());
@@ skipping 285 matching lines @@
     DisableTouchHudProjection();
 }
 
 RootWindowController* GetRootWindowController(
     const aura::RootWindow* root_window) {
   return root_window ? GetRootWindowSettings(root_window)->controller : NULL;
 }
 
 }  // namespace internal
 }  // namespace ash