Only show virtual keyboard on primary root window

ash/root_window_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/root_window_controller.h"
 
 #include "ash/session_state_delegate.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 543 matching lines @@
 
   virtual void SetUp() OVERRIDE {
     CommandLine::ForCurrentProcess()->AppendSwitch(
         keyboard::switches::kEnableVirtualKeyboard);
     test::AshTestBase::SetUp();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(VirtualKeyboardRootWindowControllerTest);
 };
 

[varkha, 2013/10/04 01:54:07]

Comment what this test does.

[bshe, 2013/10/04 03:04:39]

Done.

+TEST_F(VirtualKeyboardRootWindowControllerTest,
+       VirtualKeyboardOnPrimaryRootWindowOnly) {
+  if (!SupportsMultipleDisplays())
+    return;
+
+  UpdateDisplay("500x500,500x500");
+
+  Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+  aura::RootWindow* primary_root_window = Shell::GetPrimaryRootWindow();
+  aura::RootWindow* secondary_root_window =
+      root_windows[0] == primary_root_window ?
+          root_windows[1] : root_windows[0];
+
+  aura::Window* keyboard_container = Shell::GetContainer(primary_root_window,
+      internal::kShellWindowId_VirtualKeyboardContainer);
+  ASSERT_TRUE(keyboard_container);

[varkha, 2013/10/04 01:54:07]

nit: consider inlining ASSERT_TRUE(Shell::GetContainer(...));

[bshe, 2013/10/04 03:04:39]

Done.

+  keyboard_container = Shell::GetContainer(secondary_root_window,
+      internal::kShellWindowId_VirtualKeyboardContainer);
+  ASSERT_FALSE(keyboard_container);
+}
+
 // Test for http://crbug.com/263599. Virtual keyboard should be able to receive
 // events at blocked user session.
 TEST_F(VirtualKeyboardRootWindowControllerTest,
        ClickVirtualKeyboardInBlockedWindow) {
-  aura::RootWindow* root_window = ash::Shell::GetPrimaryRootWindow();
+  aura::RootWindow* root_window = Shell::GetPrimaryRootWindow();
   aura::Window* keyboard_container = Shell::GetContainer(root_window,
       internal::kShellWindowId_VirtualKeyboardContainer);
   ASSERT_TRUE(keyboard_container);
   keyboard_container->Show();
 
   ClickTestWindow* main_delegate = new ClickTestWindow();
   scoped_ptr<aura::Window> keyboard_window(
       main_delegate->CreateTestWindowWithParent(keyboard_container));
   keyboard_container->layout_manager()->OnWindowResized();
   keyboard_window->Show();
   aura::test::EventGenerator event_generator(root_window,
                                              keyboard_window.get());
   event_generator.ClickLeftButton();
   int expected_mouse_presses = 1;
   EXPECT_EQ(expected_mouse_presses, main_delegate->mouse_presses());
 
   for (int block_reason = FIRST_BLOCK_REASON;
        block_reason < NUMBER_OF_BLOCK_REASONS;
        ++block_reason) {
     BlockUserSession(static_cast<UserSessionBlockReason>(block_reason));
     event_generator.ClickLeftButton();
     expected_mouse_presses++;
     EXPECT_EQ(expected_mouse_presses, main_delegate->mouse_presses());
     UnblockUserSession();
   }
 }
 
 }  // namespace test
 }  // namespace ash