src/counters.cc - Issue 2511093002: [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/counters.cc

Issue 2511093002: [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters. (Closed)

Patch Set: moar tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/counters.cc

diff --git a/src/counters.cc b/src/counters.cc

index 5089eb22e8ba397dc7108af37071dd2a74915cde..6d9c9cb112bd2f76c50b64140527c44c471d3414 100644

--- a/src/counters.cc

+++ b/src/counters.cc

@@ -354,7 +354,7 @@ void RuntimeCallStats::CorrectCurrentCounterId(RuntimeCallStats* stats,

void RuntimeCallStats::Print(std::ostream& os) {

RuntimeCallStatEntries entries;

if (current_timer_.Value() != nullptr) {

- current_timer_.Value()->Elapsed();

+ current_timer_.Value()->Snapshot();

}

for (const RuntimeCallStats::CounterId counter_id :

RuntimeCallStats::counters) {