Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2511083003: VM: [Kernel] Make NativeFieldWrapperClass[1-4] constructible when running from Kernel. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Make NativeFieldWrapperClass[1-4] constructible when running from Kernel. For unclear reason sdk/lib/html/dartium/nativewrappers.dart had these classes with constructors that would throw. In reality on Kernel ever uses this file so nobody would use these constructors before anyway. When running Kernel binaries we need to be able to construct subclasses of these classes - so they need to have non-throwing constructors. R=kustermann@google.com BUG=http://dartbug.com/27590 Committed: https://github.com/dart-lang/sdk/commit/57af30e2d557b643e8d4fa04180fd3c47b49af47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -27 lines) Patch
M sdk/lib/html/dartium/nativewrappers.dart View 1 chunk +4 lines, -25 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-17 17:56:23 UTC) #1
kustermann
lgtm
4 years, 1 month ago (2016-11-17 17:57:19 UTC) #2
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-17 17:59:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57af30e2d557b643e8d4fa04180fd3c47b49af47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698