Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2511073002: Skip independent inherited property propagation to pseudo elements. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 1887 matching lines...) Expand 10 before | Expand all | Expand 10 after
1898 didRecalcStyle(change); 1898 didRecalcStyle(change);
1899 1899
1900 if (change == Reattach) 1900 if (change == Reattach)
1901 reattachWhitespaceSiblingsIfNeeded(nextTextSibling); 1901 reattachWhitespaceSiblingsIfNeeded(nextTextSibling);
1902 } 1902 }
1903 1903
1904 PassRefPtr<ComputedStyle> Element::propagateInheritedProperties( 1904 PassRefPtr<ComputedStyle> Element::propagateInheritedProperties(
1905 StyleRecalcChange change) { 1905 StyleRecalcChange change) {
1906 if (change != IndependentInherit) 1906 if (change != IndependentInherit)
1907 return nullptr; 1907 return nullptr;
1908 if (isPseudoElement())
1909 return nullptr;
1908 if (needsStyleRecalc()) 1910 if (needsStyleRecalc())
1909 return nullptr; 1911 return nullptr;
1910 if (hasAnimations()) 1912 if (hasAnimations())
1911 return nullptr; 1913 return nullptr;
1912 const ComputedStyle* parentStyle = parentComputedStyle(); 1914 const ComputedStyle* parentStyle = parentComputedStyle();
1913 DCHECK(parentStyle); 1915 DCHECK(parentStyle);
1914 const ComputedStyle* style = computedStyle(); 1916 const ComputedStyle* style = computedStyle();
1915 if (!style || style->animations() || style->transitions()) 1917 if (!style || style->animations() || style->transitions())
1916 return nullptr; 1918 return nullptr;
1917 RefPtr<ComputedStyle> newStyle = ComputedStyle::clone(*style); 1919 RefPtr<ComputedStyle> newStyle = ComputedStyle::clone(*style);
(...skipping 2165 matching lines...) Expand 10 before | Expand all | Expand 10 after
4083 } 4085 }
4084 4086
4085 DEFINE_TRACE_WRAPPERS(Element) { 4087 DEFINE_TRACE_WRAPPERS(Element) {
4086 if (hasRareData()) { 4088 if (hasRareData()) {
4087 visitor->traceWrappers(elementRareData()); 4089 visitor->traceWrappers(elementRareData());
4088 } 4090 }
4089 ContainerNode::traceWrappers(visitor); 4091 ContainerNode::traceWrappers(visitor);
4090 } 4092 }
4091 4093
4092 } // namespace blink 4094 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698