Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Issue 2511043004: [ObjC ARC] Converts ios/chrome/browser/google:google_logo to ARC.Automatically generated ARCMigra… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/google:google_logo to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/86f0d15d008ee8616bc96ad5274e6f43f39e6c18 Cr-Commit-Position: refs/heads/master@{#433257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/google/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/google/google_logo_service.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/google/google_logo_service_factory.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
stkhapugin
ptal
4 years, 1 month ago (2016-11-18 16:30:49 UTC) #4
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-11-18 16:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511043004/1
4 years, 1 month ago (2016-11-18 18:36:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 18:49:21 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:54:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86f0d15d008ee8616bc96ad5274e6f43f39e6c18
Cr-Commit-Position: refs/heads/master@{#433257}

Powered by Google App Engine
This is Rietveld 408576698