Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3261)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

Issue 2511043002: [Mac] Omnibox icons active states (Closed)
Patch Set: Cleaned up Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
index d4748223026f58eff418bd750a1f95fd922b8ab6..bb9328526cc976fe86435f64a984ba6649183c82 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
@@ -7,12 +7,13 @@
#include <memory>
#include "base/mac/scoped_nsobject.h"
-#import "chrome/browser/ui/cocoa/base_bubble_controller.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h"
#import "chrome/browser/ui/cocoa/has_weak_browser_pointer.h"
+#import "chrome/browser/ui/cocoa/omnibox_icon_bubble_controller.h"
@class BookmarkBubbleController;
@class BubbleSyncPromoController;
+class LocationBarDecoration;
namespace bookmarks {
class BookmarkBubbleObserver;
@@ -26,7 +27,7 @@ class ManagedBookmarkService;
// add or remove it as a bookmark. This bubble allows for editing of
// the bookmark in various ways (name, folder, etc.)
@interface BookmarkBubbleController
- : BaseBubbleController<HasWeakBrowserPointer> {
+ : OmniboxIconBubbleController<HasWeakBrowserPointer> {
@private
// |managed_|, |model_| and |node_| are weak and owned by the current
// browser's profile.
@@ -49,6 +50,9 @@ class ManagedBookmarkService;
IBOutlet NSTextField* nameTextField_;
IBOutlet NSPopUpButton* folderPopUpButton_;
IBOutlet NSView* syncPromoPlaceholder_;
+
+ // The star icon in the omnibox.
+ LocationBarDecoration* decoration_; // weak
}
@property(readonly, nonatomic) const bookmarks::BookmarkNode* node;

Powered by Google App Engine
This is Rietveld 408576698