[Mac] Omnibox icons active states

chrome/browser/ui/cocoa/omnibox_icon_bubble_controller.mm

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "chrome/browser/ui/cocoa/omnibox_icon_bubble_controller.h"
+
+#import <Cocoa/Cocoa.h>
+
+#import "chrome/browser/ui/cocoa/browser_window_controller.h"
+#import "chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h"
+
+// Base bubble controller class.
+@implementation OmniboxIconBubbleController
+
+- (void)showWindow:(id)sender {
+  LocationBarDecoration* decoration = [self decorationForBubble];
+  if (decoration)
+    decoration->SetActive(true);
+
+  [super showWindow:sender];
+}
+
+- (void)close {
+  LocationBarDecoration* decoration = [self decorationForBubble];
+  if (decoration)
+    decoration->SetActive(false);
+
+  [super close];
+}
+
+- (LocationBarDecoration*)decorationForBubble {

[Robert Sesek, 2016/11/21 19:28:23]

A lot of subclasses are now having to store this in their own decoration_ ivar.
I kind of think this should be an argument to the initializer, but
BaseBubbleController has 3 unique ones. Do the bubbles you are changing only use
one initializer, by any chance?

[spqchan, 2016/11/23 22:58:54]

I agree, I wanted to put it in the initializer but unfortunately, the bubbles
use more than one which makes things complex =/

[Robert Sesek, 2016/11/28 22:46:59]

Acknowledged. I figured that'd be the case. Hopefully views will sweep all this
under the rug!

+  NOTREACHED();
+  return nullptr;
+}
+
+@end