Update the build rule for media router tests (e2e) and the mapping.

Update the build rule for media router tests (e2e) and the mapping.

Committed: https://crrev.com/f7655edbb2d890252f39f345f9ec8f96798abd09
Cr-Commit-Position: refs/heads/master@{#434860}

[cliffordcheng1, 2016-11-18 21:31:21]

cliffordcheng@chromium.org changed reviewers:
+ leilei@chromium.org, mfoltz@google.com

[cliffordcheng1, 2016-11-18 21:32:02]

cliffordcheng@chromium.org changed reviewers:
+ imcheng@chromium.org

[Lei Lei, 2016-11-18 22:50:23]

lgtm

lgtm

I think you need approval from one of the owners in
https://cs.chromium.org/chromium/src/testing/buildbot/OWNERS?sq=package:chromium

[cliffordcheng1, 2016-11-18 22:57:40]

On 2016/11/18 22:50:23, Lei Lei wrote:
> lgtm
> 
> lgtm
> 
> I think you need approval from one of the owners in
>
https://cs.chromium.org/chromium/src/testing/buildbot/OWNERS?sq=package:chromium

I forget to add. Thanks for the reminder.

[cliffordcheng1, 2016-11-18 22:57:56]

cliffordcheng@chromium.org changed reviewers:
+ sky@chromium.org

[cliffordcheng1, 2016-11-21 23:45:16]

cliffordcheng@chromium.org changed reviewers:
+ maruel@chromium.org

[imcheng, 2016-11-28 19:01:08]

lgtm

[M-A Ruel, 2016-11-28 21:32:16]

lgtm with style nit.

https://codereview.chromium.org/2511033002/diff/50001/testing/buildbot/gn_iso...
File testing/buildbot/gn_isolate_map.pyl (right):

https://codereview.chromium.org/2511033002/diff/50001/testing/buildbot/gn_iso...
testing/buildbot/gn_isolate_map.pyl:565: "args": ["--extension",
"mr_extension/",
Please make the formatting like the others "script" entries, basically one flag
per line so the file itself stays internally consistent.

[cliffordcheng1, 2016-11-28 21:47:46]

https://codereview.chromium.org/2511033002/diff/50001/testing/buildbot/gn_iso...
File testing/buildbot/gn_isolate_map.pyl (right):

https://codereview.chromium.org/2511033002/diff/50001/testing/buildbot/gn_iso...
testing/buildbot/gn_isolate_map.pyl:565: "args": ["--extension",
"mr_extension/",
On 2016/11/28 21:32:16, M-A Ruel wrote:
> Please make the formatting like the others "script" entries, basically one
flag
> per line so the file itself stays internally consistent.

Done.

[M-A Ruel, 2016-11-28 21:48:44]

thanks!

[cliffordcheng1, 2016-11-28 23:50:40]

The CQ bit was checked by cliffordcheng@chromium.org

[cliffordcheng1, 2016-11-28 23:50:40]

The patchset sent to the CQ was uploaded after l-g-t-m from leilei@chromium.org,
imcheng@chromium.org, maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2511033002/#ps70001
(title: "Update the build rule for media router tests (e2e) and the mapping.")

[cliffordcheng1, 2016-11-28 23:51:29]

The CQ bit was unchecked by cliffordcheng@chromium.org

[cliffordcheng1, 2016-11-28 23:51:36]

The CQ bit was checked by cliffordcheng@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:53:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-11-29 01:03:56]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-11-29 01:03:56]

lgtm

[cliffordcheng1, 2016-11-29 01:04:37]

The CQ bit was checked by cliffordcheng@chromium.org

[cliffordcheng1, 2016-11-29 01:04:37]

The patchset sent to the CQ was uploaded after l-g-t-m from leilei@chromium.org,
imcheng@chromium.org, maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2511033002/#ps90001
(title: "Update the build rule for media router tests (e2e) and the mapping.")

[commit-bot: I haz the power, 2016-11-29 01:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 03:07:59]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1480381477010680,
"parent_rev": "b1e894d09b6107aa6c0ee685f3046b10fe4e354a", "commit_rev":
"44f335d03692dcf4839fae63536362ffef1cad3a"}

[commit-bot: I haz the power, 2016-11-29 03:08:26]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-11-29 03:11:15]

Description was changed from

==========
Update the build rule for media router tests (e2e) and the mapping.
==========

to

==========
Update the build rule for media router tests (e2e) and the mapping.

Committed: https://crrev.com/f7655edbb2d890252f39f345f9ec8f96798abd09
Cr-Commit-Position: refs/heads/master@{#434860}
==========

[commit-bot: I haz the power, 2016-11-29 03:11:15]

Patchset 6 (id:??) landed as
https://crrev.com/f7655edbb2d890252f39f345f9ec8f96798abd09
Cr-Commit-Position: refs/heads/master@{#434860}