Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: ash/wm/overview/window_selector_item.cc

Issue 251103005: Added arrow key navigation to Overview Mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added reposition animation, shortened movement time, fixed what Terry commented. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector_item.cc
diff --git a/ash/wm/overview/window_selector_item.cc b/ash/wm/overview/window_selector_item.cc
index 77d06f39738585e7810bc30cbae5498f9f3d3941..762a772f5d4e797475301042ec6962f9853f8e3a 100644
--- a/ash/wm/overview/window_selector_item.cc
+++ b/ash/wm/overview/window_selector_item.cc
@@ -56,6 +56,8 @@ views::Widget* CreateWindowLabel(aura::Window* root_window,
label->SetShadowColors(kLabelShadow, kLabelShadow);
label->SetShadowOffset(0, kVerticalShadowOffset);
label->set_shadow_blur(kShadowBlur);
+ // TODO(dmassoni): Change to something more appropriate.
+ label->set_accessible_role(ui::AX_ROLE_BUTTON);
flackr 2014/05/29 20:04:25 I think it would be better if you used a LabelButt
Nina 2014/06/02 22:04:38 Modifying where we send the a11y alert made this c
ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
label->SetFontList(bundle.GetFontList(ui::ResourceBundle::BoldFont));
label->SetText(title);
@@ -154,7 +156,6 @@ void WindowSelectorItem::UpdateWindowLabels(const gfx::Rect& window_bounds,
window_label_->GetNativeWindow()->SetBounds(label_bounds);
}
}
-
}
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698