Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 251103004: Revert of fix contents of render_pictures JSON summary (Closed)

Created:
6 years, 7 months ago by caryclark
Modified:
6 years, 7 months ago
Reviewers:
epoger, scroggo
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of fix contents of render_pictures JSON summary (https://codereview.chromium.org/259703002/) Reason for revert: This appears to have caused regressions such as this one: http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release/builds/2117/steps/CheckForRegressions/logs/stdio Original issue's description: > fix contents of render_pictures JSON summary > > BUG=skia:2043, skia:2044, skia:1942 > > Committed: http://code.google.com/p/skia/source/detail?r=14391 TBR=scroggo@google.com,epoger@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2043, skia:2044, skia:1942 Committed: http://code.google.com/p/skia/source/detail?r=14399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -162 lines) Patch
M tools/PictureRenderer.cpp View 6 chunks +35 lines, -17 lines 0 comments Download
M tools/render_pictures_main.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M tools/tests/render_pictures_test.py View 6 chunks +132 lines, -143 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
Created Revert of fix contents of render_pictures JSON summary
6 years, 7 months ago (2014-04-28 14:06:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/251103004/1
6 years, 7 months ago (2014-04-28 14:06:58 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 14:07:13 UTC) #3
Message was sent while issue was closed.
Change committed as 14399

Powered by Google App Engine
This is Rietveld 408576698