Issue 251103003: Remove unnecessary includes of v8 headers from platform files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251103003: Remove unnecessary includes of v8 headers from platform files (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove unnecessary includes of v8 headers from platform files BUG=none R=mstarzinger@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21018

Patch Set 4 : updates #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -11 lines)			Patch
M	src/platform.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform-cygwin.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/platform-freebsd.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/platform-linux.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/platform-macos.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/platform-openbsd.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/platform-qnx.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/platform-solaris.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/platform-win32.cc	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://codereview.chromium.org/251103003/diff/20001/src/platform.h File src/platform.h (right): https://codereview.chromium.org/251103003/diff/20001/src/platform.h#newcode114 src/platform.h:114: UnaryMathFunction CreateExpFunction(); I am confused: The implementation of these ...

6 years, 7 months ago (2014-04-28 11:25:48 UTC) #2

jochen (gone - plz use gerrit)

6 years, 7 months ago (2014-04-28 13:02:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r21018 (presubmit successful).

Expand Messages | Collapse Messages

Issue 251103003: Remove unnecessary includes of v8 headers from platform files (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Messages