webkitpy: Refactor _stop_running_server for wptserve

webkitpy: Refactor _stop_running_server for wptserve

 * Always make sure the process has terminated.
 * Always clean up the pid file if it exists.
 * Don't fail if process was never started.

BUG=665769
R=tkent,qyearsley

Committed: https://crrev.com/8a66268ab69e0374e1974e70fdfbe1a51980699c
Cr-Commit-Position: refs/heads/master@{#432750}

[mithro, 2016-11-17 01:29:43]

Description was changed from

==========
webkitpy: Refactor _stop_running_server for wptserve

 * Always make sure the process has terminated.
 * Always clean up the pid file if it exists.
 * Don't fail if process was never started.

 BUG=665769
 R=tkent,qyearsley
==========

to

==========
webkitpy: Refactor _stop_running_server for wptserve

 * Always make sure the process has terminated.
 * Always clean up the pid file if it exists.
 * Don't fail if process was never started.

BUG=665769
R=tkent,qyearsley
==========

[mithro, 2016-11-17 01:32:29]

Hi,

This should stop http://crbug.com/665769 from reoccuring. It also refactors the
logic a little to try and be more reliable.

Tim 'mithro' Ansell

[qyearsley, 2016-11-17 01:46:40]

LGTM :-)

Note, looks like there's a space character before BUG= and R= in the
description, so the bug number might not be parsed correctly from the
description.

https://codereview.chromium.org/2511013002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
(right):

https://codereview.chromium.org/2511013002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py:79:
return
No need for explicit return here

[mithro, 2016-11-17 02:08:24]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 02:10:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2016-11-17 03:11:22]

The CQ bit was unchecked by tansell@chromium.org

[mithro, 2016-11-17 03:11:28]

The CQ bit was checked by tansell@chromium.org

[mithro, 2016-11-17 03:11:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2511013002/#ps20001
(title: "Remove extra return statement.")

[commit-bot: I haz the power, 2016-11-17 03:13:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:11:52]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[tkent, 2016-11-17 04:53:59]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:54:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 05:00:22]

Description was changed from

==========
webkitpy: Refactor _stop_running_server for wptserve

 * Always make sure the process has terminated.
 * Always clean up the pid file if it exists.
 * Don't fail if process was never started.

BUG=665769
R=tkent,qyearsley
==========

to

==========
webkitpy: Refactor _stop_running_server for wptserve

 * Always make sure the process has terminated.
 * Always clean up the pid file if it exists.
 * Don't fail if process was never started.

BUG=665769
R=tkent,qyearsley
==========

[commit-bot: I haz the power, 2016-11-17 05:00:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 05:05:07]

Description was changed from

==========
webkitpy: Refactor _stop_running_server for wptserve

 * Always make sure the process has terminated.
 * Always clean up the pid file if it exists.
 * Don't fail if process was never started.

BUG=665769
R=tkent,qyearsley
==========

to

==========
webkitpy: Refactor _stop_running_server for wptserve

 * Always make sure the process has terminated.
 * Always clean up the pid file if it exists.
 * Don't fail if process was never started.

BUG=665769
R=tkent,qyearsley

Committed: https://crrev.com/8a66268ab69e0374e1974e70fdfbe1a51980699c
Cr-Commit-Position: refs/heads/master@{#432750}
==========

[commit-bot: I haz the power, 2016-11-17 05:05:09]

Patchset 2 (id:??) landed as
https://crrev.com/8a66268ab69e0374e1974e70fdfbe1a51980699c
Cr-Commit-Position: refs/heads/master@{#432750}