Issue 25110004: Don't update git url if 'read' times out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25110004: Don't update git url if 'read' times out (Closed)

Created:
7 years, 2 months ago by stuart

Modified:
7 years, 2 months ago

Reviewers:
Marc-Antoine Ruel (Google), M-A Ruel, szager1

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Don't update git url if 'read' times out Previous code checked the exit status of 'echo' instead of 'read' to determine if the 'read' command had timed out. TEST=Create a mirror of depot_tools.git, git clone it, then run ./update_depot_tools, see prompt for changing the URL, wait at least 60 seconds and verify that you get the timeout message. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=227427

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	update_depot_tools	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuart@fivemicro.com/25110004/1

7 years, 2 months ago (2013-10-08 01:48:41 UTC) #2

Message was sent while issue was closed.

Change committed as 227427

Expand Messages | Collapse Messages