session_manager: Add SessionManagerObserver interface

session_manager: Add SessionManagerObserver interface

BUG=657149
Committed: https://crrev.com/51fe4f0af27c1460447603444b2a17bfef109720
Cr-Commit-Position: refs/heads/master@{#432967}

[xiyuan, 2016-11-17 00:17:23]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 00:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-11-17 00:22:30]

xiyuan@chromium.org changed reviewers:
+ achuith@chromium.org

[xiyuan, 2016-11-17 00:22:30]

Trivial CL to add a SessionManagerObserver interface to dispatch session state.

I plan to use it to get rid of UserSessionStateObserver. But that change would
take much longer. I have blocked other mash guys for SessionStateDelegate
replacement for quite a bit and wanted to get something working based on
existing code. This CL is the minimum thing that I need in addition to the
existing UserSessionStateObserver. I would use it to finish the mojo CL then
continue on the code moving.

Thanks.

[achuithb, 2016-11-17 00:31:23]

lgtm

https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
File components/session_manager/core/session_manager_observer.h (right):

https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
components/session_manager/core/session_manager_observer.h:13: // TODO(xiyuan):
Use this to replace UserManager::UserSessionStateObserver.
Is there a bug that could be referenced here?

https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
components/session_manager/core/session_manager_observer.h:18: };
Let's add
public:
  SessionManagerObserver() = default;
protected:
  virtual ~SessionManagerObserver() = default;
private:
  DISALLOW_COPY_AND_ASSIGN(SessionManagerObserver);

[commit-bot: I haz the power, 2016-11-17 01:23:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:23:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-11-17 16:57:24]

https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
File components/session_manager/core/session_manager_observer.h (right):

https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
components/session_manager/core/session_manager_observer.h:13: // TODO(xiyuan):
Use this to replace UserManager::UserSessionStateObserver.
On 2016/11/17 00:31:23, achuithb wrote:
> Is there a bug that could be referenced here?

Done. Used my refactoring tracking bug http://crbug.com/657149 here.

https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
components/session_manager/core/session_manager_observer.h:18: };
On 2016/11/17 00:31:23, achuithb wrote:
> Let's add
> public:
>   SessionManagerObserver() = default;
> protected:
>   virtual ~SessionManagerObserver() = default;
> private:
>   DISALLOW_COPY_AND_ASSIGN(SessionManagerObserver);

Added the virtual dtor and DISALLOW_COPY_AND_ASSIGN.

Is creating a constructor for interface class recommended now?

[xiyuan, 2016-11-17 16:57:28]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:58:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-11-17 18:06:05]

On 2016/11/17 16:57:24, xiyuan wrote:
>
https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
> File components/session_manager/core/session_manager_observer.h (right):
> 
>
https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
> components/session_manager/core/session_manager_observer.h:13: //
TODO(xiyuan):
> Use this to replace UserManager::UserSessionStateObserver.
> On 2016/11/17 00:31:23, achuithb wrote:
> > Is there a bug that could be referenced here?
> 
> Done. Used my refactoring tracking bug http://crbug.com/657149 here.
> 
>
https://codereview.chromium.org/2510983002/diff/1/components/session_manager/...
> components/session_manager/core/session_manager_observer.h:18: };
> On 2016/11/17 00:31:23, achuithb wrote:
> > Let's add
> > public:
> >   SessionManagerObserver() = default;
> > protected:
> >   virtual ~SessionManagerObserver() = default;
> > private:
> >   DISALLOW_COPY_AND_ASSIGN(SessionManagerObserver);
> 
> Added the virtual dtor and DISALLOW_COPY_AND_ASSIGN.
> 
> Is creating a constructor for interface class recommended now?

I see what you mean now. Default ctor is needed since we use
DISALLOW_COPY_AND_ASSIGN. Added now.

[xiyuan, 2016-11-17 18:16:53]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2016-11-17 18:16:53]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2510983002/#ps40001
(title: "add default ctor")

[commit-bot: I haz the power, 2016-11-17 18:17:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:38:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 21:41:03]

Description was changed from

==========
session_manager: Add SessionManagerObserver interface

BUG=657149
==========

to

==========
session_manager: Add SessionManagerObserver interface

BUG=657149

Committed: https://crrev.com/51fe4f0af27c1460447603444b2a17bfef109720
Cr-Commit-Position: refs/heads/master@{#432967}
==========

[commit-bot: I haz the power, 2016-11-17 21:41:04]

Patchset 3 (id:??) landed as
https://crrev.com/51fe4f0af27c1460447603444b2a17bfef109720
Cr-Commit-Position: refs/heads/master@{#432967}