Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2510973002: Add support for CheckedNumeric bitshift operators (Closed)

Created:
4 years, 1 month ago by jschuh
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for CheckedNumeric bitshift operators BUG=665584 Committed: https://crrev.com/3ab540427fc419718e96e8310e817a79a837efbb Cr-Commit-Position: refs/heads/master@{#432790}

Patch Set 1 #

Patch Set 2 : format #

Total comments: 2

Patch Set 3 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -9 lines) Patch
M base/numerics/safe_math.h View 1 2 2 chunks +16 lines, -5 lines 0 comments Download
M base/numerics/safe_math_impl.h View 1 2 chunks +57 lines, -0 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 3 chunks +35 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
jschuh
ptal
4 years, 1 month ago (2016-11-17 00:21:01 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/2510973002/diff/20001/base/numerics/safe_math.h File base/numerics/safe_math.h (right): https://codereview.chromium.org/2510973002/diff/20001/base/numerics/safe_math.h#newcode120 base/numerics/safe_math.h:120: template <typename Src> nit: format as above?
4 years, 1 month ago (2016-11-17 00:29:46 UTC) #5
jschuh
https://codereview.chromium.org/2510973002/diff/20001/base/numerics/safe_math.h File base/numerics/safe_math.h (right): https://codereview.chromium.org/2510973002/diff/20001/base/numerics/safe_math.h#newcode120 base/numerics/safe_math.h:120: template <typename Src> On 2016/11/17 00:29:45, Tom Sepez wrote: ...
4 years, 1 month ago (2016-11-17 00:47:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510973002/40001
4 years, 1 month ago (2016-11-17 02:48:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/316719)
4 years, 1 month ago (2016-11-17 05:24:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510973002/40001
4 years, 1 month ago (2016-11-17 05:27:14 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 06:59:13 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 07:02:30 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ab540427fc419718e96e8310e817a79a837efbb
Cr-Commit-Position: refs/heads/master@{#432790}

Powered by Google App Engine
This is Rietveld 408576698