Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2510953003: MD Settings: drop confusing "Enable guest browsing" secondary text (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: drop confusing "Enable guest browsing" secondary text R=tommycli@chromium.org BUG=653501 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f657b97e7d7bebd7e37d615c827806fa692b4579 Cr-Commit-Position: refs/heads/master@{#432932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Dan Beam
4 years, 1 month ago (2016-11-17 04:30:51 UTC) #2
tommycli
purely deletions always lgtm
4 years, 1 month ago (2016-11-17 16:35:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510953003/1
4 years, 1 month ago (2016-11-17 19:04:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 19:36:19 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:28:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f657b97e7d7bebd7e37d615c827806fa692b4579
Cr-Commit-Position: refs/heads/master@{#432932}

Powered by Google App Engine
This is Rietveld 408576698