DevTools: all swatches should have a default focused element

third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 UI.SwatchPopoverHelper = class extends Common.Object {
   constructor() {
     super();
     this._popover = new UI.Popover();
@@ skipping 35 matching lines @@
 
       // Reopen the picker for another anchor element.
       this.hide(true);
     }
 
     delete this._isHidden;
     this._anchorElement = anchorElement;
     this._view = view;
     this._hiddenCallback = hiddenCallback;
     this.reposition();
+    view.focus();

[dgozman, 2016/11/17 01:29:50]

Shouldn't call to popover.showView handle this?

[luoe, 2016/11/17 21:38:08]

I don't think so.  Not all popovers need to take focus for themselves.  For
swatches, I think it's always reasonable for them to steal focus because
swatches open for editing, which requires user interaction.

Placing .focus() in the general popover.showView will affect popovers shown on
hover, e.g. hovering over rows/blocks in Network, Timeline, Animations panel
which are meant to be ephemeral and hide on mouseout.  If we put .focus() there,
we'd also need to put a focus restorer there, which isn't necessary.

 
     var document = this._popover.element.ownerDocument;
     document.addEventListener('mousedown', this._hideProxy, false);
     document.defaultView.addEventListener('resize', this._hideProxy, false);
     this._view.contentElement.addEventListener('keydown', this._boundOnKeyDown, false);
   }
 
   reposition() {
     // Unbind "blur" listener to avoid reenterability: |popover.showView| will hide the popover and trigger it synchronously.
     this._view.contentElement.removeEventListener('focusout', this._boundFocusOut, false);
@@ skipping 37 matching lines @@
       this.hide(true);
       event.consume(true);
       return;
     }
     if (event.key === 'Escape') {
       this.hide(false);
       event.consume(true);
     }
   }
 };