device/vr/vr_device.h - Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/vr_device.h

Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)

Patch Set: Fix FakeVRDevice Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/vr_device.h

diff --git a/device/vr/vr_device.h b/device/vr/vr_device.h

index 688dd041d42919039e5da12a74b162ee8fa5539c..5f6107706f3aca4deb953f40ec959480152939eb 100644

--- a/device/vr/vr_device.h

+++ b/device/vr/vr_device.h

@@ -35,7 +35,8 @@ class DEVICE_VR_EXPORT VRDevice {

virtual mojom::VRPosePtr GetPose() = 0;

virtual void ResetPose() = 0;

- virtual bool RequestPresent(bool secure_origin) = 0;

+ virtual void RequestPresent(const base::Callback<void(bool)>& callback) = 0;

+ virtual void SetSecureOrigin(bool secure_origin) = 0;

virtual void ExitPresent() = 0;

virtual void SubmitFrame(mojom::VRPosePtr pose) = 0;

virtual void UpdateLayerBounds(mojom::VRLayerBoundsPtr left_bounds,

« no previous file with comments | « device/vr/test/fake_vr_device.cc ('k') | device/vr/vr_device.cc » ('j') | no next file with comments »