device/vr/android/gvr/gvr_delegate.h - Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/android/gvr/gvr_delegate.h

Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)

Patch Set: Fix FakeVRDevice Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/android/gvr/gvr_delegate.h

diff --git a/device/vr/android/gvr/gvr_delegate.h b/device/vr/android/gvr/gvr_delegate.h

index 556924720a1e573c23e308b36390e28c4694ba35..e6f672154e4191f9fa1f4d8009bffa1107f43490 100644

--- a/device/vr/android/gvr/gvr_delegate.h

+++ b/device/vr/android/gvr/gvr_delegate.h

@@ -37,8 +37,9 @@ class DEVICE_VR_EXPORT GvrDelegateProvider {

static void SetInstance(GvrDelegateProvider* delegate_provider);

static GvrDelegateProvider* GetInstance();

- virtual bool RequestWebVRPresent(

- base::WeakPtr<GvrDeviceProvider> device_provider) = 0;

+ virtual void RequestWebVRPresent(

+ base::WeakPtr<GvrDeviceProvider> device_provider,

+ const base::Callback<void(bool)>& callback) = 0;

virtual void ExitWebVRPresent() = 0;

virtual base::WeakPtr<GvrDelegate> GetNonPresentingDelegate() = 0;

virtual void DestroyNonPresentingDelegate() = 0;