Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)
Patch Set: Fix FakeVRDevice Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 81e3f0a7f7ddf701bebd435b19ef3857e3e7ddb0..36c99355f99b19d569e91cbeb5154be31cb2711c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -653,7 +653,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
if (mVrShellDelegate.isVrIntent(intent)) {
// TODO(mthiesse): Improve startup when started from a VR intent. Right now
// we launch out of VR, partially load out of VR, then switch into VR.
- mVrShellDelegate.enterVRIfNecessary(false);
+ mVrShellDelegate.enterVRIfNecessary();
} else if (!mIntentHandler.shouldIgnoreIntent(ChromeTabbedActivity.this, intent)) {
mIntentWithEffect = mIntentHandler.onNewIntent(ChromeTabbedActivity.this,
intent);
@@ -1199,7 +1199,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
if (!currentModel.isIncognito()) currentModel.openMostRecentlyClosedTab();
RecordUserAction.record("MobileTabClosedUndoShortCut");
} else if (id == R.id.enter_vr_id) {
- mVrShellDelegate.enterVRIfNecessary(false);
+ mVrShellDelegate.enterVRIfNecessary();
} else {
return super.onMenuOrKeyboardAction(id, fromMenu);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698