Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8933)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/vr/vr_device.h

Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('K') | « device/vr/android/gvr/gvr_device_provider.cc ('k') | device/vr/vr_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/vr/vr_device.h
diff --git a/device/vr/vr_device.h b/device/vr/vr_device.h
index 688dd041d42919039e5da12a74b162ee8fa5539c..5f6107706f3aca4deb953f40ec959480152939eb 100644
--- a/device/vr/vr_device.h
+++ b/device/vr/vr_device.h
@@ -35,7 +35,8 @@ class DEVICE_VR_EXPORT VRDevice {
virtual mojom::VRPosePtr GetPose() = 0;
virtual void ResetPose() = 0;
- virtual bool RequestPresent(bool secure_origin) = 0;
+ virtual void RequestPresent(const base::Callback<void(bool)>& callback) = 0;
+ virtual void SetSecureOrigin(bool secure_origin) = 0;
virtual void ExitPresent() = 0;
virtual void SubmitFrame(mojom::VRPosePtr pose) = 0;
virtual void UpdateLayerBounds(mojom::VRLayerBoundsPtr left_bounds,
« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('K') | « device/vr/android/gvr/gvr_device_provider.cc ('k') | device/vr/vr_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698