device/vr/android/gvr/gvr_device_provider.h - Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/android/gvr/gvr_device_provider.h

Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)

Patch Set: Address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/android/gvr/gvr_device_provider.h

diff --git a/device/vr/android/gvr/gvr_device_provider.h b/device/vr/android/gvr/gvr_device_provider.h

index 1eaa9872261c89b93a9219a91e9b51add32f6957..0e1d879393e1b86c8f3e36eb63f149f80e4f641b 100644

--- a/device/vr/android/gvr/gvr_device_provider.h

+++ b/device/vr/android/gvr/gvr_device_provider.h

@@ -30,7 +30,7 @@ class DEVICE_VR_EXPORT GvrDeviceProvider : public VRDeviceProvider {

void Initialize() override;

// Called from GvrDevice.

- bool RequestPresent();

+ void RequestPresent(const base::Callback<void(bool)>& callback);

void ExitPresent();

void OnGvrDelegateReady(const base::WeakPtr<GvrDelegate>& delegate);