chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java - Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java

Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)

Patch Set: Address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | chrome/browser/android/vr_shell/vr_shell_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java

index 50e70100f654ab6a204845d7259195b9b516fb8a..360769f04e78109b2321e3eb5f527b8954929fb1 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java

@@ -35,7 +35,7 @@ public class VrShellTest extends ChromeTabbedActivityTestBase {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- mDelegate.enterVRIfNecessary(false);

+ mDelegate.enterVRIfNecessary();

}

});

}