Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 2510843002: [turbofan] Improve handling of TransitionElementsKind in load elimination. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve handling of TransitionElementsKind in load elimination. We do not have to invalidate the abstract state if we are transitioning to the object's map. Committed: https://crrev.com/1929f80a3a3ff0bfa8cdb97f2aa6f444071ba3e4 Cr-Commit-Position: refs/heads/master@{#41053}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address reviewer's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/compiler/load-elimination.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Could you take a look, please? This fixes up Octane crypto's hot loop.
4 years, 1 month ago (2016-11-16 20:21:05 UTC) #4
Benedikt Meurer
LGTM with nit. Thanks! https://codereview.chromium.org/2510843002/diff/1/src/compiler/load-elimination.cc File src/compiler/load-elimination.cc (right): https://codereview.chromium.org/2510843002/diff/1/src/compiler/load-elimination.cc#newcode872 src/compiler/load-elimination.cc:872: if (target_map == object_map) { ...
4 years, 1 month ago (2016-11-16 20:22:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510843002/20001
4 years, 1 month ago (2016-11-16 20:28:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 20:56:08 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:37:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1929f80a3a3ff0bfa8cdb97f2aa6f444071ba3e4
Cr-Commit-Position: refs/heads/master@{#41053}

Powered by Google App Engine
This is Rietveld 408576698