third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl - Issue 2510833002: PaymentApp: Add interfaces for PaymentRequestEvent.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

Issue 2510833002: PaymentApp: Add interfaces for PaymentRequestEvent. (Closed)

Patch Set: PaymentApp: Add interfaces for PaymentRequestEvent. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentrequesteve nt

	6

	7 [

	8 RuntimeEnabled=PaymentApp,

	9 Exposed=ServiceWorker

	10 ] interface PaymentRequestEvent : ExtendableEvent {

	11 readonly attribute PaymentAppRequestData data;

	12 void respondWith(Promise<PaymentResponse> response);
	please use gerrit instead 2016/11/21 20:31:36 The spec says: void respondWith((Promise<PaymentR The spec says: void respondWith((Promise<PaymentResponse> or PaymentResponse) r); zino 2016/11/21 23:22:13 IMHO, the spec should be respondWith(Promise<Payme Show quoted text On 2016/11/21 20:31:36, rouslan wrote: > The spec says: > > void respondWith((Promise<PaymentResponse> or PaymentResponse) r); IMHO, the spec should be respondWith(Promise<PaymentResponse> response); We can refer to existing example (in service worker): https://github.com/w3c/ServiceWorker/issues/724 Another example is updateWith in PaymentRequestUpdateEvent.idl. So, I sent a pull request to fix this to the spec repo. - https://github.com/w3c/webpayments-payment-apps-api/pull/71
	13 };

OLD	NEW