Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: runtime/vm/assembler_arm64.h

Issue 251083007: Removes loads from PP from stubs on arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_ARM64_H_ 5 #ifndef VM_ASSEMBLER_ARM64_H_
6 #define VM_ASSEMBLER_ARM64_H_ 6 #define VM_ASSEMBLER_ARM64_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_arm64.h directly; use assembler.h instead. 9 #error Do not include assembler_arm64.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 663 matching lines...) Expand 10 before | Expand all | Expand 10 after
674 } 674 }
675 675
676 // Fixed length branch to label. 676 // Fixed length branch to label.
677 void BranchFixed(const ExternalLabel* label) { 677 void BranchFixed(const ExternalLabel* label) {
678 LoadImmediateFixed(TMP, label->address()); 678 LoadImmediateFixed(TMP, label->address());
679 br(TMP); 679 br(TMP);
680 } 680 }
681 681
682 void BranchLink(const ExternalLabel* label, Register pp) { 682 void BranchLink(const ExternalLabel* label, Register pp) {
683 if (Isolate::Current() == Dart::vm_isolate()) { 683 if (Isolate::Current() == Dart::vm_isolate()) {
684 LoadImmediate(TMP, label->address(), kNoRegister); 684 LoadImmediate(TMP, label->address(), kNoPP);
685 blr(TMP); 685 blr(TMP);
686 } else { 686 } else {
687 LoadExternalLabel(TMP, label, kNotPatchable, pp); 687 LoadExternalLabel(TMP, label, kNotPatchable, pp);
688 blr(TMP); 688 blr(TMP);
689 } 689 }
690 } 690 }
691 691
692 void BranchLinkPatchable(const ExternalLabel* label) { 692 void BranchLinkPatchable(const ExternalLabel* label) {
693 LoadExternalLabel(TMP, label, kPatchable, PP); 693 LoadExternalLabel(TMP, label, kPatchable, PP);
694 blr(TMP); 694 blr(TMP);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 void LeaveCallRuntimeFrame(); 774 void LeaveCallRuntimeFrame();
775 void CallRuntime(const RuntimeEntry& entry, intptr_t argument_count); 775 void CallRuntime(const RuntimeEntry& entry, intptr_t argument_count);
776 776
777 // Set up a stub frame so that the stack traversal code can easily identify 777 // Set up a stub frame so that the stack traversal code can easily identify
778 // a stub frame. 778 // a stub frame.
779 void EnterStubFrame(bool load_pp = false); 779 void EnterStubFrame(bool load_pp = false);
780 void LeaveStubFrame(); 780 void LeaveStubFrame();
781 781
782 void UpdateAllocationStats(intptr_t cid, 782 void UpdateAllocationStats(intptr_t cid,
783 Register temp_reg, 783 Register temp_reg,
784 Register pp,
784 Heap::Space space = Heap::kNew); 785 Heap::Space space = Heap::kNew);
785 786
786 private: 787 private:
787 AssemblerBuffer buffer_; // Contains position independent code. 788 AssemblerBuffer buffer_; // Contains position independent code.
788 789
789 // Objects and patchable jump targets. 790 // Objects and patchable jump targets.
790 GrowableObjectArray& object_pool_; 791 GrowableObjectArray& object_pool_;
791 792
792 // Patchability of pool entries. 793 // Patchability of pool entries.
793 GrowableArray<Patchability> patchable_pool_entries_; 794 GrowableArray<Patchability> patchable_pool_entries_;
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
1114 Register value, 1115 Register value,
1115 Label* no_update); 1116 Label* no_update);
1116 1117
1117 DISALLOW_ALLOCATION(); 1118 DISALLOW_ALLOCATION();
1118 DISALLOW_COPY_AND_ASSIGN(Assembler); 1119 DISALLOW_COPY_AND_ASSIGN(Assembler);
1119 }; 1120 };
1120 1121
1121 } // namespace dart 1122 } // namespace dart
1122 1123
1123 #endif // VM_ASSEMBLER_ARM64_H_ 1124 #endif // VM_ASSEMBLER_ARM64_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698