Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2510823004: LayoutTests: prepare test expectations for V8 change. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: prepare test expectations for V8 change. Function source of built-in functions implemented in C++ and installed by blink will switch from "function() {}" to "function() { [native code] }". The latter is in line with C++ built-ins installed by V8 itself. R=machenbach@chromium.org BUG=666223 NOTRY=true Committed: https://crrev.com/e8ad7835b9311d05d39a66c121cb9300e8121ee0 Cr-Commit-Position: refs/heads/master@{#432819}

Patch Set 1 #

Patch Set 2 : move lines to avoid conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Achenbach
lgtm
4 years, 1 month ago (2016-11-17 08:30:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510823004/20001
4 years, 1 month ago (2016-11-17 08:47:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 08:54:12 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 08:58:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8ad7835b9311d05d39a66c121cb9300e8121ee0
Cr-Commit-Position: refs/heads/master@{#432819}

Powered by Google App Engine
This is Rietveld 408576698