Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2510823002: [inspector] remove profiler->collectSample from V8StackTraceImpl::capture (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
alph
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] remove profiler->collectSample from V8StackTraceImpl::capture Now we don't need to call collectSample on each V8StackTraceImpl::capture during collecting profile. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel BUG=none R=alph@chromium.org,dgozman@chromium.org Committed: https://crrev.com/c8cff606c2190a8ea3d5e03aeb8b6c6e23006e4b Cr-Commit-Position: refs/heads/master@{#41051}

Patch Set 1 #

Patch Set 2 : removed collectSample method from profiler agent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M src/inspector/v8-profiler-agent-impl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/inspector/v8-profiler-agent-impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/inspector/v8-stack-trace-impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kozy
Alexey, please take a look.
4 years, 1 month ago (2016-11-16 18:56:34 UTC) #4
alph
lgtm
4 years, 1 month ago (2016-11-16 19:49:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510823002/20001
4 years, 1 month ago (2016-11-16 19:51:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 19:57:06 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:37:03 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8cff606c2190a8ea3d5e03aeb8b6c6e23006e4b
Cr-Commit-Position: refs/heads/master@{#41051}

Powered by Google App Engine
This is Rietveld 408576698