Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 2510803003: Pass RapporService to content/browser/ (Closed)
Patch Set: Add a test for the current url API Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_browsertest.cc
diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc
index 28a1ab37940c517c1c9d9dbc01674bec55a3cd78..a10bca9c5b4a21358ebcf93ab069616405f948de 100644
--- a/content/browser/web_contents/web_contents_impl_browsertest.cc
+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc
@@ -626,6 +626,9 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,
shell()->LoadURL(url);
tab_observer.Wait();
EXPECT_EQ(url, shell()->web_contents()->GetLastCommittedURL());
+ EXPECT_EQ(std::string("foo.com"),
+ static_cast<WebContentsImpl*>(shell()->web_contents())
+ ->getRapporCommittedUrl());
Charlie Reis 2016/11/16 23:55:22 This doesn't seem related to this test. We should
Navid Zolghadr 2016/12/01 18:27:15 Done.
// We should have gotten to DidStopLoading.
EXPECT_TRUE(delegate->did_stop_loading);

Powered by Google App Engine
This is Rietveld 408576698