Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.h

Issue 2510803003: Pass RapporService to content/browser/ (Closed)
Patch Set: Fix more compile errors in JNI files Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model.h
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.h b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
index 10e8d96e7f14493cab46fc2ab7add1ee156e6005..10bd07d9ba9888b7b4b00c322fcb871d90a15085 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.h
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
@@ -33,7 +33,7 @@ class WebContents;
}
namespace rappor {
-class RapporService;
+class RapporServiceImpl;
}
// The hierarchy of bubble models:
@@ -176,7 +176,8 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
AsSubresourceFilterBubbleModel();
// Sets the Rappor service used for testing.
- void SetRapporServiceForTesting(rappor::RapporService* rappor_service) {
+ void SetRapporServiceImplForTesting(
+ rappor::RapporServiceImpl* rappor_service) {
rappor_service_ = rappor_service;
}
@@ -233,7 +234,7 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
void set_setting_is_managed(bool managed) {
setting_is_managed_ = managed;
}
- rappor::RapporService* rappor_service() const { return rappor_service_; }
+ rappor::RapporServiceImpl* rappor_service() const { return rappor_service_; }
private:
virtual void SetTitle() = 0;
@@ -249,7 +250,7 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
// controlled by the user.
bool setting_is_managed_;
// The service used to record Rappor metrics. Can be set for testing.
- rappor::RapporService* rappor_service_;
+ rappor::RapporServiceImpl* rappor_service_;
DISALLOW_COPY_AND_ASSIGN(ContentSettingBubbleModel);
};

Powered by Google App Engine
This is Rietveld 408576698