Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6280)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2510803003: Pass RapporService to content/browser/ (Closed)
Patch Set: Fix more compile errors in JNI files Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index f7333bed0aba9fe5a2af9a75e979f3b7b9bed805..e594fa97a06483d3f0dcbe60fd64c9a34b3fe6d4 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -10,8 +10,8 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
-#include "components/rappor/rappor_service.h"
-#include "components/rappor/rappor_utils.h"
+#include "components/rappor/public/rappor_utils.h"
+#include "components/rappor/rappor_service_impl.h"
#include "net/http/http_response_headers.h"
#include "ui/base/page_transition_types.h"
@@ -614,7 +614,8 @@ void CorePageLoadMetricsObserver::RecordRappor(
// IsShuttingDown() first.
if (g_browser_process->IsShuttingDown())
return;
- rappor::RapporService* rappor_service = g_browser_process->rappor_service();
+ rappor::RapporServiceImpl* rappor_service =
+ g_browser_process->rappor_service();
if (!rappor_service)
return;
if (info.committed_url.is_empty())
@@ -636,8 +637,8 @@ void CorePageLoadMetricsObserver::RecordRappor(
// was > 10s.
sample->SetFlagsField(
"IsSlow", timing.first_contentful_paint.value().InSecondsF() >= 10, 1);
- rappor_service->RecordSampleObj(internal::kRapporMetricsNameCoarseTiming,
- std::move(sample));
+ rappor_service->RecordSample(internal::kRapporMetricsNameCoarseTiming,
+ std::move(sample));
}
// Log the eTLD+1 of sites that did not report first meaningful paint.

Powered by Google App Engine
This is Rietveld 408576698