chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc - Issue 2510803003: Pass RapporService to content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

Issue 2510803003: Pass RapporService to content/browser/ (Closed)

Patch Set: Applying comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | components/rappor/public/rappor_public_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

index 03c8ca384271cca660b61611476756fb1c96a2f8..84cf40e08028954cf3c5870a7de4f2d755f1536b 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

@@ -103,7 +103,7 @@ IN_PROC_BROWSER_TEST_F(ContentSettingsMixedScriptIgnoreCertErrorsTest,

replace_host.SetHostStr("example.test");

url = url.ReplaceComponents(replace_host);

- rappor::TestRapporService rappor_service;

+ rappor::TestRapporServiceImpl rappor_service;

EXPECT_EQ(0, rappor_service.GetReportsCount());

base::HistogramTester histograms;

histograms.ExpectTotalCount("ContentSettings.MixedScript", 0);

@@ -121,7 +121,7 @@ IN_PROC_BROWSER_TEST_F(ContentSettingsMixedScriptIgnoreCertErrorsTest,

browser()->content_setting_bubble_model_delegate(),

browser()->tab_strip_model()->GetActiveWebContents(),

browser()->profile(), CONTENT_SETTINGS_TYPE_MIXEDSCRIPT));

- model->SetRapporServiceForTesting(&rappor_service);

+ model->SetRapporServiceImplForTesting(&rappor_service);

model->OnCustomLinkClicked();

// Wait for reload