chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc - Issue 2510803003: Pass RapporService to content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc

Issue 2510803003: Pass RapporService to content/browser/ (Closed)

Patch Set: Applying comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/navigation_metrics_recorder.cc ('k') | chrome/browser/task_manager/task_manager_interface.h » ('j') | components/rappor/public/rappor_public_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc

diff --git a/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc b/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc

index 94105db70073465013e0f8bb663bf952868db1a7..5318d9837004480fe8a9471b363f328db9ee9d8e 100644

--- a/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc

+++ b/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc

@@ -25,7 +25,7 @@ IN_PROC_BROWSER_TEST_F(NavigationMetricsRecorderBrowserTest, TestMetrics) {

content::WebContentsUserData<NavigationMetricsRecorder>::FromWebContents(

web_contents);

ASSERT_TRUE(recorder);

- rappor::TestRapporService rappor_service;

+ rappor::TestRapporServiceImpl rappor_service;

recorder->set_rappor_service_for_testing(&rappor_service);

base::HistogramTester histograms;