Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4827)

Unified Diff: chrome/browser/plugins/plugin_info_message_filter.cc

Issue 2510803003: Pass RapporService to content/browser/ (Closed)
Patch Set: Applying comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_info_message_filter.cc
diff --git a/chrome/browser/plugins/plugin_info_message_filter.cc b/chrome/browser/plugins/plugin_info_message_filter.cc
index 2fdaaeabc89fb2608d6e93f2ccbd7398afef2c31..7a5e145bc1e3c975560d447964038582500bf175 100644
--- a/chrome/browser/plugins/plugin_info_message_filter.cc
+++ b/chrome/browser/plugins/plugin_info_message_filter.cc
@@ -36,7 +36,7 @@
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/content_settings/core/common/content_settings.h"
#include "components/prefs/pref_service.h"
-#include "components/rappor/rappor_service.h"
+#include "components/rappor/rappor_service_impl.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/plugin_service.h"
#include "content/public/browser/plugin_service_filter.h"
@@ -98,7 +98,8 @@ void ReportMetrics(const std::string& mime_type,
if (chrome::IsIncognitoSessionActive())
return;
- rappor::RapporService* rappor_service = g_browser_process->rappor_service();
+ rappor::RapporServiceImpl* rappor_service =
+ g_browser_process->rappor_service();
if (!rappor_service)
return;
if (main_frame_origin.unique())
@@ -106,16 +107,15 @@ void ReportMetrics(const std::string& mime_type,
if (mime_type == content::kFlashPluginSwfMimeType ||
mime_type == content::kFlashPluginSplMimeType) {
- rappor_service->RecordSample(
+ rappor_service->RecordSampleString(
"Plugins.FlashOriginUrl", rappor::ETLD_PLUS_ONE_RAPPOR_TYPE,
net::registry_controlled_domains::GetDomainAndRegistry(
main_frame_origin.GetURL(),
net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));
- rappor_service->RecordSample(
+ rappor_service->RecordSampleString(
"Plugins.FlashUrl", rappor::ETLD_PLUS_ONE_RAPPOR_TYPE,
net::registry_controlled_domains::GetDomainAndRegistry(
- url,
- net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));
+ url, net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));
}
}

Powered by Google App Engine
This is Rietveld 408576698