chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 2510803003: Pass RapporService to content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2510803003: Pass RapporService to content/browser/ (Closed)

Patch Set: Applying comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_initialize.cc » ('j') | components/rappor/public/rappor_public_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index 712466a20a33f1b1dbcd4b59caf8b3910b7345f6..773e54abacff0a5b8935428472c013472073dfae 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -8,7 +8,7 @@

#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"

#include "chrome/test/base/testing_browser_process.h"

-#include "components/rappor/rappor_utils.h"

+#include "components/rappor/public/rappor_utils.h"

#include "components/rappor/test_rappor_service.h"

namespace {

@@ -28,10 +28,10 @@ class CorePageLoadMetricsObserverTest

void SetUp() override {

page_load_metrics::PageLoadMetricsObserverTestHarness::SetUp();

- TestingBrowserProcess::GetGlobal()->SetRapporService(&rappor_tester_);

+ TestingBrowserProcess::GetGlobal()->SetRapporServiceImpl(&rappor_tester_);

}

- rappor::TestRapporService rappor_tester_;

+ rappor::TestRapporServiceImpl rappor_tester_;

};

TEST_F(CorePageLoadMetricsObserverTest, NoMetrics) {