Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2148)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/plugins/plugin_info_message_filter.cc

Issue 2510803003: Pass RapporService to content/browser/ (Closed)
Patch Set: Fix an Android compile error Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('K') | « chrome/browser/permissions/permission_uma_util.cc ('k') | chrome/browser/prefs/pref_metrics_service.cc » ('j') | chrome/browser/tab_contents/navigation_metrics_recorder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_info_message_filter.cc
diff --git a/chrome/browser/plugins/plugin_info_message_filter.cc b/chrome/browser/plugins/plugin_info_message_filter.cc
index 2fdaaeabc89fb2608d6e93f2ccbd7398afef2c31..740c7670fb02e364fa62e256466379fafec692c2 100644
--- a/chrome/browser/plugins/plugin_info_message_filter.cc
+++ b/chrome/browser/plugins/plugin_info_message_filter.cc
@@ -106,12 +106,12 @@ void ReportMetrics(const std::string& mime_type,
if (mime_type == content::kFlashPluginSwfMimeType ||
mime_type == content::kFlashPluginSplMimeType) {
- rappor_service->RecordSample(
+ rappor_service->RecordSampleString(
"Plugins.FlashOriginUrl", rappor::ETLD_PLUS_ONE_RAPPOR_TYPE,
net::registry_controlled_domains::GetDomainAndRegistry(
main_frame_origin.GetURL(),
net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));
- rappor_service->RecordSample(
+ rappor_service->RecordSampleString(
"Plugins.FlashUrl", rappor::ETLD_PLUS_ONE_RAPPOR_TYPE,
net::registry_controlled_domains::GetDomainAndRegistry(
url,
« chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('K') | « chrome/browser/permissions/permission_uma_util.cc ('k') | chrome/browser/prefs/pref_metrics_service.cc » ('j') | chrome/browser/tab_contents/navigation_metrics_recorder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698