Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 2510803003: Pass RapporService to content/browser/ (Closed)
Patch Set: Add a test for the current url API Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 struct FaviconURL; 88 struct FaviconURL;
89 struct LoadNotificationDetails; 89 struct LoadNotificationDetails;
90 struct MHTMLGenerationParams; 90 struct MHTMLGenerationParams;
91 struct ResourceRedirectDetails; 91 struct ResourceRedirectDetails;
92 struct ResourceRequestDetails; 92 struct ResourceRequestDetails;
93 93
94 namespace mojom { 94 namespace mojom {
95 class CreateNewWindowParams; 95 class CreateNewWindowParams;
96 } 96 }
97 97
98 namespace rappor {
99 class RapporService;
100 }
101
98 #if defined(OS_ANDROID) 102 #if defined(OS_ANDROID)
99 class WebContentsAndroid; 103 class WebContentsAndroid;
100 #endif 104 #endif
101 105
102 #if defined(ENABLE_PLUGINS) 106 #if defined(ENABLE_PLUGINS)
103 class PepperPlaybackObserver; 107 class PepperPlaybackObserver;
104 #endif 108 #endif
105 109
106 // Factory function for the implementations that content knows about. Takes 110 // Factory function for the implementations that content knows about. Takes
107 // ownership of |delegate|. 111 // ownership of |delegate|.
(...skipping 24 matching lines...) Expand all
132 136
133 static WebContentsImpl* FromFrameTreeNode(FrameTreeNode* frame_tree_node); 137 static WebContentsImpl* FromFrameTreeNode(FrameTreeNode* frame_tree_node);
134 static WebContents* FromRenderFrameHostID(int render_process_host_id, 138 static WebContents* FromRenderFrameHostID(int render_process_host_id,
135 int render_frame_host_id); 139 int render_frame_host_id);
136 static WebContents* FromFrameTreeNodeId(int frame_tree_node_id); 140 static WebContents* FromFrameTreeNodeId(int frame_tree_node_id);
137 141
138 // Complex initialization here. Specifically needed to avoid having 142 // Complex initialization here. Specifically needed to avoid having
139 // members call back into our virtual functions in the constructor. 143 // members call back into our virtual functions in the constructor.
140 virtual void Init(const WebContents::CreateParams& params); 144 virtual void Init(const WebContents::CreateParams& params);
141 145
146 ::rappor::RapporService* getRapporService() override;
Charlie Reis 2016/11/16 23:55:22 These need to be in the correct override section o
Navid Zolghadr 2016/12/01 18:27:15 Done.
147 std::string getRapporCommittedUrl() override;
148
142 // Returns the SavePackage which manages the page saving job. May be NULL. 149 // Returns the SavePackage which manages the page saving job. May be NULL.
143 SavePackage* save_package() const { return save_package_.get(); } 150 SavePackage* save_package() const { return save_package_.get(); }
144 151
145 #if defined(OS_ANDROID) 152 #if defined(OS_ANDROID)
146 // In Android WebView, the RenderView needs created even there is no 153 // In Android WebView, the RenderView needs created even there is no
147 // navigation entry, this allows Android WebViews to use 154 // navigation entry, this allows Android WebViews to use
148 // javascript: URLs that load into the DOMWindow before the first page 155 // javascript: URLs that load into the DOMWindow before the first page
149 // load. This is not safe to do in any context that a web page could get a 156 // load. This is not safe to do in any context that a web page could get a
150 // reference to the DOMWindow before the first page load. 157 // reference to the DOMWindow before the first page load.
151 bool CreateRenderViewForInitialEmptyDocument(); 158 bool CreateRenderViewForInitialEmptyDocument();
(...skipping 1305 matching lines...) Expand 10 before | Expand all | Expand 10 after
1457 // Adds/removes a callback called on creation of each new WebContents. 1464 // Adds/removes a callback called on creation of each new WebContents.
1458 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1465 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1459 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1466 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1460 1467
1461 DISALLOW_COPY_AND_ASSIGN(FriendZone); 1468 DISALLOW_COPY_AND_ASSIGN(FriendZone);
1462 }; 1469 };
1463 1470
1464 } // namespace content 1471 } // namespace content
1465 1472
1466 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1473 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698