Pass RapporService to content/browser/

components/rappor/public/rappor_public_service.h

+// Copyright 2014 The Chromium Authors. All rights reserved.

[ncarter (slow), 2016/12/01 22:33:32]

2016

[Navid Zolghadr, 2016/12/02 20:47:35]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_RAPPOR_RAPPOR_PUBLIC_SERVICE_H_
+#define COMPONENTS_RAPPOR_RAPPOR_PUBLIC_SERVICE_H_
+
+#include <memory>
+#include <string>
+
+#include "base/memory/weak_ptr.h"
+#include "components/rappor/public/rappor_parameters.h"
+#include "components/rappor/public/sample.h"
+
+namespace rappor {
+
+// This class provides a public interface for recording samples for rappor
+// metrics, which other components can be depended on.
+class RapporPublicService : public base::SupportsWeakPtr<RapporService> {

[ncarter (slow), 2016/12/01 22:33:32]

I'm not opposed to this name (and ultimately it's a components/rappor OWNER's
call). But the following name pairs strike me as being more conventional
choices:

public/ RapporService & non-public RapporServiceImpl

or 

public/ RapporServiceInterface & non-public RapporService

or call it something based on what features it actually exposes (something like
rappor::SampleCollector).

[Navid Zolghadr, 2016/12/02 20:47:35]

Although holte@ gave lgtm but I believe what you are suggesting is better that
what it is. I used RapporService and RapporServiceImpl. This made this change a
little bigger. But I have the renaming in a separate commit from the rest of
your comments. Let me know if you would like me to break the renaming into
another CL or is it good to keep it as is.

[ncarter (slow), 2016/12/05 19:50:49]

Thanks for doing the rename.

+ public:
+  // Constructs a Sample object for the caller to record fields in.
+  virtual std::unique_ptr<Sample> CreateSample(RapporType) = 0;
+
+  // Records a Sample of rappor metric specified by |metric_name|.
+  //
+  // example:
+  // std::unique_ptr<Sample> sample =
+  // rappor_service->CreateSample(MY_METRIC_TYPE);
+  // sample->SetStringField("Field1", "some string");
+  // sample->SetFlagsValue("Field2", SOME|FLAGS);
+  // rappor_service->RecordSample("MyMetric", std::move(sample));
+  virtual void RecordSample(const std::string& metric_name,
+                            std::unique_ptr<Sample> sample) = 0;
+
+  // Records a sample of the rappor metric specified by |metric_name|.
+  // Creates and initializes the metric, if it doesn't yet exist.
+  virtual void RecordSampleString(const std::string& metric_name,
+                                  RapporType type,
+                                  const std::string& sample) = 0;
+};
+
+}  // namespace rappor
+
+#endif  // COMPONENTS_RAPPOR_RAPPOR_PUBLIC_SERVICE_H_