components/rappor/public/BUILD.gn - Issue 2510803003: Pass RapporService to content/browser/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/rappor/public/BUILD.gn

Issue 2510803003: Pass RapporService to content/browser/ (Closed)

Patch Set: Fix an Android compile error Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("public") {
	ncarter (slow) 2016/12/01 22:33:32 Do you reference this anywhere? Do you reference this anywhere? Navid Zolghadr 2016/12/02 20:47:35 There is one reference from components/rappor/BUIL Show quoted text On 2016/12/01 22:33:32, ncarter wrote: > Do you reference this anywhere? There is one reference from components/rappor/BUILD.gn. But I wasn't very confident what to put in this file. I mainly looked around and found similar stuff. Should I change this to something else? ncarter (slow) 2016/12/05 19:50:49 I'm kind of clueless too about BUILD.gn. I'm basic Show quoted text On 2016/12/02 20:47:35, Navid Zolghadr wrote: > On 2016/12/01 22:33:32, ncarter wrote: > > Do you reference this anywhere? > > There is one reference from components/rappor/BUILD.gn. But I wasn't very > confident what to put in this file. I mainly looked around and found similar > stuff. Should I change this to something else? I'm kind of clueless too about BUILD.gn. I'm basically okay with anything that compiles.
	6 sources = [

	7 "rappor_parameters.h",

	8 "rappor_public_service.h",

	9 "rappor_utils.h",

	10 "sample.h",

	11 ]

	12

	13 deps = [

	14 "//base",

	15 ]

	16 }

OLD	NEW