Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 25108007: Fixed debuggersupport=off build after r16521 (Closed)

Created:
7 years, 2 months ago by Weiliang
Modified:
7 years, 2 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fixed debuggersupport=off build after r16521 BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/d8-debug.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Weiliang
https://code.google.com/p/v8/issues/detail?id=2913
7 years, 2 months ago (2013-09-30 04:59:30 UTC) #1
Yang
lgtm. I had to add another change in objects.h to make it compile though.
7 years, 2 months ago (2013-10-01 07:50:13 UTC) #2
Yang
7 years, 2 months ago (2013-10-01 07:53:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17025.

Powered by Google App Engine
This is Rietveld 408576698