Issue 251080: Sync: Remove pthreads from event_sys code. Remove asynch version of GaiaAuthe...

Issue 251080: Sync: Remove pthreads from event_sys code. Remove asynch version of GaiaAuthe... (Closed)

Created:
11 years, 2 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
chron_chromium.org

CC:
chromium-reviews_googlegroups.com, ncarter (slow), fbarchard, Alpha Left Google, idana, awong, Paweł Hajdan Jr., ben+cc_chromium.org, darin (slow to review), tim (not reviewing), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sync: Remove pthreads from event_sys code. Remove asynch version of GaiaAuthenticator, as it is never used. This allowed replacing all lock/mutex code with current MessageLoop assertions. Some temp scaffolding in auth_watcher (e.g creating a message loop for the current pthread), which will be removed as part of my next trick. TEST=sync_unit_tests suite, sync_integration_tests suite BUG=19895 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27956

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 6

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -151 lines)			Patch
M	chrome/browser/sync/engine/all_status.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/auth_watcher.h	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/auth_watcher.cc	View	1 2 3 4	2 chunks	+37 lines, -19 lines	0 comments	Download
M	chrome/browser/sync/engine/authenticator.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/client_command_channel.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/net/gaia_authenticator.h	View	1 2 3 4	7 chunks	+24 lines, -32 lines	0 comments	Download
M	chrome/browser/sync/engine/net/gaia_authenticator.cc	View	1 2 3 4	9 chunks	+16 lines, -60 lines	0 comments	Download
M	chrome/browser/sync/engine/net/gaia_authenticator_unittest.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/net/server_connection_manager.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncer_types.h	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/notifier/listener/talk_mediator.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/syncable/syncable.h	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/util/event_sys.h	View	1 2 3 4	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/util/event_sys-inl.h	View	1 2 3 4	11 chunks	+27 lines, -26 lines	0 comments	Download
M	chrome/browser/sync/util/event_sys_unittest.cc	View	1 2 3 4	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

chron_chromium.org

http://codereview.chromium.org/251080/diff/1017/22 File chrome/browser/sync/engine/auth_watcher.cc (right): http://codereview.chromium.org/251080/diff/1017/22#newcode262 Line 262: bool authenticated; I think you may need to ...

11 years, 2 months ago (2009-10-02 22:11:10 UTC) #2

tim (not reviewing)

11 years, 2 months ago (2009-10-02 22:22:05 UTC) #4

http://codereview.chromium.org/251080/diff/1017/22
File chrome/browser/sync/engine/auth_watcher.cc (right):

http://codereview.chromium.org/251080/diff/1017/22#newcode262
Line 262: bool authenticated;
On 2009/10/02 22:11:10, chron_chromium.org wrote:
> I think you may need to indent a bit here

Done.

http://codereview.chromium.org/251080/diff/1017/22#newcode263
Line 263: if (!args->captcha_token.empty() && !args->captcha_value.empty())
On 2009/10/02 22:11:10, chron_chromium.org wrote:
> Can you sprinkle a few braces for clarity?

Totally.

http://codereview.chromium.org/251080/diff/1017/22#newcode281
Line 281: break;
On 2009/10/02 22:11:10, chron_chromium.org wrote:
> Wow, this might be clearer with a goto. Can you leave a note here to refactor
> this into a function? 

Done.  I'm rewriting this loop as we speak as part of my next CL.

Expand Messages | Collapse Messages