Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 2510773002: Remove Precise builders from webkitpy/common/config/builders.py. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, bokan
CC:
blink-reviews, chromium-reviews, Dirk Pranke, bokan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Precise builders from webkitpy/common/config/builders.py. BUG=660580 Committed: https://crrev.com/fa1cd57377dfd8deb6bfd9797c49313ea6a45361 Cr-Commit-Position: refs/heads/master@{#433042}

Patch Set 1 #

Patch Set 2 : Fix access to protected attributes in update_test_expectations_unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -130 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py View 2 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py View 1 27 chunks +118 lines, -117 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
qyearsley
4 years, 1 month ago (2016-11-16 18:43:45 UTC) #2
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-16 19:52:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510773002/1
4 years, 1 month ago (2016-11-17 18:13:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/339767)
4 years, 1 month ago (2016-11-17 19:38:50 UTC) #7
qyearsley
This CL now also updates update_test_expectations_unittest.py, since the values used in that test depend on ...
4 years, 1 month ago (2016-11-17 23:04:08 UTC) #9
bokan
lgtm
4 years, 1 month ago (2016-11-17 23:16:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510773002/20001
4 years, 1 month ago (2016-11-17 23:37:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-18 01:10:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510773002/20001
4 years, 1 month ago (2016-11-18 01:59:04 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 03:08:36 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 03:11:00 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa1cd57377dfd8deb6bfd9797c49313ea6a45361
Cr-Commit-Position: refs/heads/master@{#433042}

Powered by Google App Engine
This is Rietveld 408576698