|
|
Chromium Code Reviews
DescriptionRemove Precise builders from webkitpy/common/config/builders.py.
BUG=660580
Committed: https://crrev.com/fa1cd57377dfd8deb6bfd9797c49313ea6a45361
Cr-Commit-Position: refs/heads/master@{#433042}
Patch Set 1 #Patch Set 2 : Fix access to protected attributes in update_test_expectations_unittest #
Messages
Total messages: 26 (15 generated)
qyearsley@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
This CL now also updates update_test_expectations_unittest.py, since the values used in that test depend on the values in config/builders.py (since MockHost also uses those values by default). In addition it makes a small change to MockPortFactory in that test in order to pass pylint.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bokan@chromium.org changed reviewers: + bokan@chromium.org
lgtm
The CQ bit was unchecked by qyearsley@chromium.org
The CQ bit was checked by qyearsley@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2510773002/#ps20001 (title: "Fix access to protected attributes in update_test_expectations_unittest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by qyearsley@chromium.org
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove Precise builders from webkitpy/common/config/builders.py. BUG=660580 ========== to ========== Remove Precise builders from webkitpy/common/config/builders.py. BUG=660580 Committed: https://crrev.com/fa1cd57377dfd8deb6bfd9797c49313ea6a45361 Cr-Commit-Position: refs/heads/master@{#433042} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fa1cd57377dfd8deb6bfd9797c49313ea6a45361 Cr-Commit-Position: refs/heads/master@{#433042} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
