Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: components/printing/test/print_web_view_helper_browsertest.cc

Issue 2510753002: Revert of Make printing work better with OOPIF. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/printing/test/print_web_view_helper_browsertest.cc
diff --git a/components/printing/test/print_web_view_helper_browsertest.cc b/components/printing/test/print_web_view_helper_browsertest.cc
index 6609fbc59fffe91b322581fb4665a40c7c5fcbf7..5ed2d75a7273f10ea3ece2863f9b155f6f2e6b96 100644
--- a/components/printing/test/print_web_view_helper_browsertest.cc
+++ b/components/printing/test/print_web_view_helper_browsertest.cc
@@ -18,7 +18,6 @@
#include "components/printing/test/mock_printer.h"
#include "components/printing/test/print_mock_render_thread.h"
#include "components/printing/test/print_test_content_renderer_client.h"
-#include "content/public/renderer/render_frame.h"
#include "content/public/renderer/render_view.h"
#include "content/public/test/render_view_test.h"
#include "ipc/ipc_listener.h"
@@ -225,7 +224,7 @@
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
void OnPrintPages() {
- GetPrintWebViewHelper()->OnPrintPages();
+ PrintWebViewHelper::Get(view_)->OnPrintPages();
ProcessPendingMessages();
}
#endif // BUILDFLAG(ENABLE_BASIC_PRINTING)
@@ -240,7 +239,7 @@
}
void OnPrintPreview(const base::DictionaryValue& dict) {
- PrintWebViewHelper* print_web_view_helper = GetPrintWebViewHelper();
+ PrintWebViewHelper* print_web_view_helper = PrintWebViewHelper::Get(view_);
print_web_view_helper->OnInitiatePrintPreview(false);
base::RunLoop run_loop;
DidPreviewPageListener filter(&run_loop);
@@ -253,15 +252,10 @@
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
void OnPrintForPrintPreview(const base::DictionaryValue& dict) {
- GetPrintWebViewHelper()->OnPrintForPrintPreview(dict);
+ PrintWebViewHelper::Get(view_)->OnPrintForPrintPreview(dict);
ProcessPendingMessages();
}
#endif // BUILDFLAG(ENABLE_BASIC_PRINTING)
-
- PrintWebViewHelper* GetPrintWebViewHelper() {
- return PrintWebViewHelper::Get(
- content::RenderFrame::FromWebFrame(GetMainFrame()));
- }
// Naked pointer as ownership is with content::RenderViewTest::render_thread_.
PrintMockRenderThread* print_render_thread_;
@@ -308,7 +302,7 @@
VerifyPagesPrinted(false);
// Unblock script initiated printing and verify printing works.
- GetPrintWebViewHelper()->scripting_throttler_.Reset();
+ PrintWebViewHelper::Get(view_)->scripting_throttler_.Reset();
print_render_thread_->printer()->ResetPrinter();
PrintWithJavaScript();
VerifyPageCount(1);
@@ -395,11 +389,12 @@
// Find the frame and set it as the focused one. This should mean that that
// the printout should only contain the contents of that frame.
- auto* web_view = view_->GetWebView();
- WebFrame* sub1_frame = web_view->findFrameByName(WebString::fromUTF8("sub1"));
+ WebFrame* sub1_frame =
+ view_->GetWebView()->findFrameByName(WebString::fromUTF8("sub1"));
ASSERT_TRUE(sub1_frame);
- web_view->setFocusedFrame(sub1_frame);
- ASSERT_NE(web_view->focusedFrame(), web_view->mainFrame());
+ view_->GetWebView()->setFocusedFrame(sub1_frame);
+ ASSERT_NE(view_->GetWebView()->focusedFrame(),
+ view_->GetWebView()->mainFrame());
// Initiate printing.
OnPrintPages();
@@ -628,12 +623,12 @@
TEST_F(MAYBE_PrintWebViewHelperPreviewTest, BlockScriptInitiatedPrinting) {
LoadHTML(kHelloWorldHTML);
- PrintWebViewHelper* print_web_view_helper = GetPrintWebViewHelper();
- print_web_view_helper->OnSetPrintingEnabled(false);
+ PrintWebViewHelper* print_web_view_helper = PrintWebViewHelper::Get(view_);
+ print_web_view_helper->SetScriptedPrintBlocked(true);
PrintWithJavaScript();
VerifyPreviewRequest(false);
- print_web_view_helper->OnSetPrintingEnabled(true);
+ print_web_view_helper->SetScriptedPrintBlocked(false);
PrintWithJavaScript();
VerifyPreviewRequest(true);
}
« no previous file with comments | « components/printing/test/print_test_content_renderer_client.cc ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698