Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2510753002: Revert of Make printing work better with OOPIF. (Closed)

Created:
4 years, 1 month ago by sgurun-gerrit only
Modified:
4 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make printing work better with OOPIF. (patchset #17 id:340001 of https://codereview.chromium.org/2426503002/ ) Reason for revert: webview printing cts test fails. Original issue's description: > Make printing work better with OOPIF. > > BUG=631513 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818 > Cr-Commit-Position: refs/heads/master@{#432353} TBR=rockot@chromium.org,lukasza@chromium.org,nasko@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631513 Committed: https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832 Cr-Commit-Position: refs/heads/master@{#432507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -534 lines) Patch
M android_webview/browser/aw_print_manager.h View 1 chunk +2 lines, -7 lines 0 comments Download
M android_webview/browser/aw_print_manager.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_print_web_view_helper_delegate.h View 1 chunk +3 lines, -5 lines 0 comments Download
M android_webview/renderer/aw_print_web_view_helper_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M android_webview/renderer/print_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_unittest.cc View 10 chunks +11 lines, -17 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 4 chunks +11 lines, -16 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 8 chunks +40 lines, -71 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.h View 6 chunks +10 lines, -21 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 11 chunks +49 lines, -73 lines 0 comments Download
M chrome/browser/printing/print_view_manager_common.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/printing/print_view_manager_common.cc View 3 chunks +6 lines, -38 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 5 chunks +21 lines, -16 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/chrome_pdf_print_client.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/printing/chrome_print_web_view_helper_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M components/printing/browser/print_manager.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/printing/browser/print_manager.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M components/printing/common/print_messages.h View 2 chunks +21 lines, -16 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.h View 9 chunks +23 lines, -19 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 14 chunks +76 lines, -60 lines 0 comments Download
M components/printing/test/print_test_content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/test/print_test_content_renderer_client.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 7 chunks +12 lines, -17 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M content/public/browser/render_frame_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/renderer/render_frame_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_message_macros.h View 2 chunks +0 lines, -17 lines 0 comments Download
M ipc/ipc_message_templates.h View 3 chunks +2 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sgurun-gerrit only
Created Revert of Make printing work better with OOPIF.
4 years, 1 month ago (2016-11-16 16:11:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510753002/1
4 years, 1 month ago (2016-11-16 16:12:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 16:13:37 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832 Cr-Commit-Position: refs/heads/master@{#432507}
4 years, 1 month ago (2016-11-16 16:15:56 UTC) #6
Lei Zhang
lgtm, but can you give me some pointers on what failed on how I can ...
4 years, 1 month ago (2016-11-16 18:23:48 UTC) #7
Lei Zhang
4 years, 1 month ago (2016-11-16 18:25:14 UTC) #8
Message was sent while issue was closed.
On 2016/11/16 18:23:48, Lei Zhang (not reviewing code) wrote:
> lgtm, but can you give me some pointers on what failed on how I can repro?

n/m, I saw the activity on the bug.

Powered by Google App Engine
This is Rietveld 408576698