Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2510743003: [regexp] Fix matching of regexps that are both sticky and anchored at end. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix matching of regexps that are both sticky and anchored at end. V8 was applying incorrect optimization to them advancing the start position. This would cause /foo$/y too match "barfoo", which it should not. BUG= Committed: https://crrev.com/29745ee927bf1f4cb3e0b0075d0a149575000f18 Cr-Commit-Position: refs/heads/master@{#41077}

Patch Set 1 #

Patch Set 2 : Reformat #

Patch Set 3 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/regexp/jsregexp.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/es6/regexp-sticky.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Vyacheslav Egorov (Google)
Found a small bug in irregexp while implementing similar sticky functionality in Dart VM.
4 years, 1 month ago (2016-11-17 13:26:52 UTC) #2
Yang
On 2016/11/17 13:26:52, Vyacheslav Egorov (Google) wrote: > Found a small bug in irregexp while ...
4 years, 1 month ago (2016-11-17 13:28:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510743003/40001
4 years, 1 month ago (2016-11-17 13:34:11 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 13:58:28 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:21 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/29745ee927bf1f4cb3e0b0075d0a149575000f18
Cr-Commit-Position: refs/heads/master@{#41077}

Powered by Google App Engine
This is Rietveld 408576698