[interpreter] Bytecode for StaDataPropertyInLiteral.

src/interpreter/bytecode-generator.cc

Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index fc7b1155d940a74fc780385df4b13bd0b896969c..0ec1cad05640af9e96e7fc33dade8ca4b91275f2 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -1480,8 +1480,10 @@ void BytecodeGenerator::VisitClassLiteralProperties(ClassLiteral* expr,
       case ClassLiteral::Property::METHOD: {
         builder()
             ->LoadLiteral(Smi::FromInt(property->NeedsSetFunctionName()))
-            .StoreAccumulatorInRegister(set_function_name)
-            .CallRuntime(Runtime::kDefineDataPropertyInLiteral, args);
+            .StoreAccumulatorInRegister(set_function_name);
+        builder()->LoadAccumulatorWithRegister(value);

[rmcilroy, 2016/11/17 17:18:17]

nit - rather than having value to be in the accumulator, how about just having
set_function_name be in the accumulator and keep value in a register, that way
the bytecode sequence could be:
 ->LoadLiteral(Smi::FromInt(property->NeedsSetFunctionName()))
  .StoreDataPropertyInLiteral(receiver, key, attr, value);

which would save two extra bytecodes.

[Franzi, 2016/11/18 09:11:53]

Done.

+        builder()->StoreDataPropertyInLiteral(receiver, key, attr,

[rmcilroy, 2016/11/17 17:18:17]

nit - just chain the builder calls together like those above.

[Franzi, 2016/11/18 09:11:53]

Done.

+                                              set_function_name);
         break;
       }
       case ClassLiteral::Property::GETTER: {
@@ -1710,7 +1712,9 @@ void BytecodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
             .StoreAccumulatorInRegister(args[3])
             .LoadLiteral(Smi::FromInt(property->NeedsSetFunctionName()))
             .StoreAccumulatorInRegister(args[4]);
-        builder()->CallRuntime(Runtime::kDefineDataPropertyInLiteral, args);
+        builder()->LoadAccumulatorWithRegister(args[2]);
+        builder()->StoreDataPropertyInLiteral(args[0], args[1], args[3],

[rmcilroy, 2016/11/17 17:18:17]

ditto

[Franzi, 2016/11/18 09:11:53]

Done.

+                                              args[4]);
         break;
       }
       case ObjectLiteral::Property::GETTER: